Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-sdk: Implement automatic MigrationHandler derivation #1483

Merged
merged 6 commits into from
Sep 14, 2023
Merged

runtime-sdk: Implement automatic MigrationHandler derivation #1483

merged 6 commits into from
Sep 14, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 12, 2023 •
edited
Loading

TODO

  • Tests for the new MigrationHandler derivation.
  • Also derive the Module trait.

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #1483 (a66d706) into main (e9991c7) will increase coverage by 0.30%.
The diff coverage is 91.16%.

@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   59.20%   59.51%   +0.30%     
==========================================
  Files         135      138       +3     
  Lines        9615     9631      +16     
==========================================
+ Hits         5693     5732      +39     
+ Misses       3880     3857      -23     
  Partials       42       42
Files Changed Coverage Δ
runtime-sdk-macros/src/lib.rs 0.00% <0.00%> (ø)
...-sdk/modules/contracts/src/abi/oasis/validation.rs 15.10% <ø> (ø)
runtime-sdk/modules/evm/src/signed_call.rs 92.75% <ø> (ø)
runtime-sdk/modules/evm/src/types.rs 66.66% <ø> (ø)
runtime-sdk/src/dispatcher.rs 18.50% <ø> (ø)
runtime-sdk/src/modules/consensus/mod.rs 85.45% <66.66%> (+7.95%) ⬆️
...-sdk-macros/src/module_derive/migration_handler.rs 86.79% <86.79%> (ø)
runtime-sdk/src/context.rs 67.10% <88.88%> (+<0.01%) ⬆️
...ime-sdk-macros/src/module_derive/method_handler.rs 91.93% <91.93%> (ø)
runtime-sdk-macros/src/module_derive/module.rs 95.45% <95.45%> (ø)
... and 11 more

... and 32 files with indirect coverage changes

@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch 3 times, most recently from cc89807 to 8ae5a57 Compare September 13, 2023 08:33
@kostko kostko marked this pull request as ready for review September 13, 2023 08:33
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch 2 times, most recently from f6a1e31 to d4c34bc Compare September 13, 2023 13:27
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch from d4c34bc to 3a9efd6 Compare September 13, 2023 13:43
@kostko kostko force-pushed the kostko/feature/module-migrations-derive branch from 3a9efd6 to a66d706 Compare September 14, 2023 11:43
@kostko kostko merged commit fac9e70 into main Sep 14, 2023
27 checks passed
@kostko kostko deleted the kostko/feature/module-migrations-derive branch September 14, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternose peternose peternose approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostko @peternose